Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arctic-1293][Imporvement][CI]: Run code style check first when run github ci actions. #1326

Closed

Conversation

baiyangtx
Copy link
Contributor

@baiyangtx baiyangtx commented Apr 11, 2023

Why are the changes needed?

fix #1293 Run codestyle check first when run github ci actions to fast failed actions.

Brief change log

  • Add mvn validate step before mvn install
  • Add -Dcheckstyle.skip during mvn install

@baiyangtx baiyangtx changed the title [Arctic-1293][CI]: Run code style check first when run github ci actions. [Arctic-1293][Imporvement][CI]: Run code style check first when run github ci actions. Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b7246c9) 43.82% compared to head (4c5d7f4) 43.82%.

❗ Current head 4c5d7f4 differs from pull request most recent head b238fc1. Consider uploading reports for the commit b238fc1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1326   +/-   ##
=========================================
  Coverage     43.82%   43.82%           
  Complexity      539      539           
=========================================
  Files            46       46           
  Lines          4276     4276           
  Branches        502      502           
=========================================
  Hits           1874     1874           
  Misses         2206     2206           
  Partials        196      196           
Flag Coverage Δ
trino 43.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@baiyangtx
Copy link
Contributor Author

baiyangtx commented Apr 11, 2023

I find that mvn validate will failed if the project has not been installed, because the scalastyle-maven-plugin required project dependencies resolved.

Somebody meet the same problems. scalastyle/scalastyle-maven-plugin#26
But the plugin haven't been updated for 4 years.

There two solutions:

  1. Disable scala codestyle check during mvn validate and re-run validate in build steps. ( the scalastyle problem could not fail-fast)
  2. Fork a new repo for scalastyle-maven-plugin and fix the problem. ( maintain the code in netease ? )

What should we do?

@zhoujinsong CC

@github-actions github-actions bot added the module:mixed-flink Flink moduel for Mixed Format label Apr 12, 2023
@baiyangtx baiyangtx closed this Sep 20, 2023
@baiyangtx baiyangtx deleted the 1293-run-validate-first-in-ci branch September 20, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: CI run check style first
2 participants